Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor seasonal reservation #1443

Merged
merged 16 commits into from
Nov 6, 2024
Merged

Refactor seasonal reservation #1443

merged 16 commits into from
Nov 6, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Oct 7, 2024 •
edited
Loading

🛠️ Changelog

  • Preliminary refactors for applications / seasonal reservations pages.
  • Change urls to be more consistent.
  • Add: url builder functions to customer ui.
  • Fix: missing gap in seasonal search cards.
  • Fix: card's having button style overrides that made primary buttons unusable.
  • Fix: creating new application automatically set the customer type to INDIVIDUAL.
  • Refactor: remove duplicated translations.

🧪 Test plan

  • Manual testing: creating new applications and view / edit them customer ui

🎫 Tickets

@joonatank joonatank force-pushed the refactor-seasonal-reservation branch 3 times, most recently from e857900 to f3384b3 Compare October 7, 2024 13:43
@joonatank joonatank marked this pull request as ready for review October 7, 2024 13:43
@joonatank joonatank requested a review from vincit-matu October 7, 2024 13:43
@joonatank joonatank force-pushed the refactor-seasonal-reservation branch 3 times, most recently from a64af6b to c7b0105 Compare October 9, 2024 08:44
@joonatank joonatank force-pushed the refactor-seasonal-reservation branch 3 times, most recently from acdb5c3 to 9ce43f7 Compare October 18, 2024 11:26
@joonatank joonatank force-pushed the refactor-seasonal-reservation branch 3 times, most recently from 9f54174 to 675f90c Compare October 24, 2024 09:51
@joonatank
fix: missing gap on seasonal search page
d1fcf06
@joonatank
fix: button styling
76cec1d 
- All secondary buttons / link buttons use white background.
- Remove overrides from buttons inside a Card.
- Replace !important overrides with focus / hover vars.
@joonatank joonatank force-pushed the refactor-seasonal-reservation branch from 029862d to 8e3ceca Compare October 28, 2024 09:55
joonatank
joonatank commented Oct 28, 2024
View reviewed changes
apps/ui/components/reservation/ReservationInfoCard.tsx Show resolved Hide resolved
apps/ui/modules/urls.ts Outdated Show resolved Hide resolved
apps/ui/modules/urls.ts Show resolved Hide resolved
apps/ui/modules/urls.ts Show resolved Hide resolved
apps/ui/pages/applications/[id]/view.tsx Show resolved Hide resolved
vincit-matu
vincit-matu approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joonatank joonatank force-pushed the refactor-seasonal-reservation branch 3 times, most recently from 9c5a563 to 99031ba Compare October 29, 2024 12:31
@joonatank
refactor: add url builders to customer ui
78eb29b
@joonatank
refactor: seasonal reservation urls
01362fd 
- move criteria and search pages under the application round
@joonatank
refactor: move application pages
5a554c7 
- use `applications` base url for all application page
- remove unnecessary intro page
@joonatank
fix: broken urls from application page moves
229b86b
@joonatank
refactor: remove koros from applications
ae9b11c
@joonatank
refactor: application view page
d6d8a73 
- use SSR for query
- include when the application was handled
- remove unneccessary button section
@joonatank
refactor: move application query
0e92647
@joonatank
fix: invalid orderBy in applications query
13ed9e0
@joonatank joonatank force-pushed the refactor-seasonal-reservation branch from 99031ba to a052039 Compare October 29, 2024 12:48
@joonatank joonatank merged commit e165c3e into main Nov 6, 2024
8 checks passed
@joonatank joonatank deleted the refactor-seasonal-reservation branch November 6, 2024 12:19
@joonatank joonatank mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vincit-matu