Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect base url in admin-ui #1441

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix incorrect base url in admin-ui #1441

merged 2 commits into from
Oct 7, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Oct 4, 2024 •
edited by jira bot
Loading

🛠️ Changelog

🧪 Test plan

  • Manual testing: deployed admin-ui should return html (not 404 errors for _next assets).

🎫 Tickets

@joonatank joonatank changed the title wip: fix incorrect base url in admin-ui fix incorrect base url in admin-ui Oct 4, 2024
@joonatank joonatank force-pushed the fix-docker-incorrect-base-url branch 4 times, most recently from c28c3ce to 544b1b6 Compare October 4, 2024 11:36
@joonatank joonatank marked this pull request as ready for review October 4, 2024 11:50
@joonatank joonatank force-pushed the fix-docker-incorrect-base-url branch 2 times, most recently from 0042a85 to 08dc278 Compare October 4, 2024 12:19
@joonatank joonatank requested a review from matti-lamppu October 4, 2024 12:21
@joonatank joonatank force-pushed the fix-docker-incorrect-base-url branch from 08dc278 to 4af0a94 Compare October 4, 2024 12:58
@joonatank joonatank force-pushed the fix-docker-incorrect-base-url branch from 60bc202 to bc6c18d Compare October 4, 2024 13:16
@joonatank joonatank requested a review from vergama October 4, 2024 13:17
@joonatank joonatank force-pushed the fix-docker-incorrect-base-url branch from 03fd567 to 6614b72 Compare October 7, 2024 05:16
@joonatank joonatank merged commit b438610 into main Oct 7, 2024
12 checks passed
@joonatank joonatank deleted the fix-docker-incorrect-base-url branch October 7, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vergama vergama vergama approved these changes

@matti-lamppu matti-lamppu Awaiting requested review from matti-lamppu

@vincit-matu vincit-matu Awaiting requested review from vincit-matu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vergama