Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KK-1403 | Add view families permission and restrict child/guardian info with it #470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karisal-anders
Copy link
Contributor

@karisal-anders karisal-anders commented Jan 20, 2025

Description

Add view families permission and restrict child/guardian info with it

Related

KK-1403

@karisal-anders karisal-anders changed the title feat: add permission to view families, e.g. child & guardian lists KK-1403 | Add permission to view families, e.g. child & guardian lists Jan 20, 2025
@karisal-anders karisal-anders changed the title KK-1403 | Add permission to view families, e.g. child & guardian lists KK-1403 | Add permission to view families Jan 20, 2025
@terovirtanen
Copy link
Contributor

KUKKUU-API branch is deployed to platta: https://kukkuu-pr470.api.dev.hel.ninja 🚀🚀🚀

@karisal-anders karisal-anders force-pushed the KK-1403-add-view-families-perm branch from dda604d to 39ff228 Compare January 20, 2025 15:37
@terovirtanen
Copy link
Contributor

KUKKUU-API branch is deployed to platta: https://kukkuu-pr470.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kukkuu-pr470.api.dev.hel.ninja 😆🎉🎉🎉

@karisal-anders karisal-anders force-pushed the KK-1403-add-view-families-perm branch from 39ff228 to 8fba5a3 Compare January 22, 2025 15:20
- children and guardians graphql endpoints (i.e. Children query and
  Guardians query) will now raise permission denied error if user does
  not have permission to view families
- user can't see any guardian's contact info (i.e. email and phone
  number) without view families permission, except their own

also:
 - refactor permission handling a bit to reduce code duplication

refs KK-1403
@karisal-anders karisal-anders force-pushed the KK-1403-add-view-families-perm branch 2 times, most recently from ac4172d to fe659b7 Compare January 23, 2025 13:27
@terovirtanen
Copy link
Contributor

KUKKUU-API branch is deployed to platta: https://kukkuu-pr470.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kukkuu-pr470.api.dev.hel.ninja 😆🎉🎉🎉

@karisal-anders karisal-anders marked this pull request as ready for review January 23, 2025 13:55
@karisal-anders karisal-anders changed the title KK-1403 | Add permission to view families KK-1403 | Add view families permission and restrict child/guardian info with it Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants