-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KK-1403 | Add view families permission and restrict child/guardian info with it #470
Open
karisal-anders
wants to merge
1
commit into
master
Choose a base branch
from
KK-1403-add-view-families-perm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karisal-anders
changed the title
feat: add permission to view families, e.g. child & guardian lists
KK-1403 | Add permission to view families, e.g. child & guardian lists
Jan 20, 2025
karisal-anders
changed the title
KK-1403 | Add permission to view families, e.g. child & guardian lists
KK-1403 | Add permission to view families
Jan 20, 2025
KUKKUU-API branch is deployed to platta: https://kukkuu-pr470.api.dev.hel.ninja 🚀🚀🚀 |
karisal-anders
force-pushed
the
KK-1403-add-view-families-perm
branch
from
January 20, 2025 15:37
dda604d
to
39ff228
Compare
KUKKUU-API branch is deployed to platta: https://kukkuu-pr470.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr470.api.dev.hel.ninja 😆🎉🎉🎉 |
karisal-anders
force-pushed
the
KK-1403-add-view-families-perm
branch
from
January 22, 2025 15:20
39ff228
to
8fba5a3
Compare
- children and guardians graphql endpoints (i.e. Children query and Guardians query) will now raise permission denied error if user does not have permission to view families - user can't see any guardian's contact info (i.e. email and phone number) without view families permission, except their own also: - refactor permission handling a bit to reduce code duplication refs KK-1403
karisal-anders
force-pushed
the
KK-1403-add-view-families-perm
branch
2 times, most recently
from
January 23, 2025 13:27
ac4172d
to
fe659b7
Compare
Quality Gate passedIssues Measures |
KUKKUU-API branch is deployed to platta: https://kukkuu-pr470.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr470.api.dev.hel.ninja 😆🎉🎉🎉 |
karisal-anders
changed the title
KK-1403 | Add permission to view families
KK-1403 | Add view families permission and restrict child/guardian info with it
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add view families permission and restrict child/guardian info with it
Related
KK-1403