New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP-1626 add min-height for main #850

Open

IiroJarv wants to merge 1 commit into develop from task/TP-1626_main_content_min_height

+9 −2

Contributor

IiroJarv commented Jan 23, 2025

Actions necessary for applying the changes: (for example composer install; drush updb; drush cim)

lando drush cr

Add min-height for the .main to offset the footer to the bottom of the site.

Testing instructions:

Go page with usually small main-content (like group page without content)
Confirm that there is no empty space under the footer

Review checklist:

The code conforms to Drupal coding standards
I have reviewed the code for security and quality issues
I have tested the code with the proper user roles
I have moved the ticket to the approval lane, added testing instructions and assigned it to the product owner.


          TP-1626 add min-height for main

b711d3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet