Merge pull request #381 from deathride58/take2branding #533
deathride58Annotations
32 warnings
|
Test Packaging
The following actions uses node12 which is deprecated and will be forced to run on node16: space-wizards/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test Packaging
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/[email protected], space-wizards/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/MarkupNode.cs#L10
'MarkupNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
|
|
Test Packaging:
RobustToolbox/Robust.Shared/ViewVariables/ViewVariablesTypeHandler.cs#L213
'Logger.ErrorS(string, Exception, string, params object?[])' is obsolete: 'Use ISawmill.Error'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/ComponentTrees/ComponentTreeSystem.cs#L291
'IMapManager.GetMapEntityId(MapId)' is obsolete: 'Use TryGetMap'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/ZStd.cs#L288
The '&' operator should not be used on parameters or local variables in async methods.
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/ZStd.cs#L288
The '&' operator should not be used on parameters or local variables in async methods.
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Toolshed/TypeParsers/StringTypeParser.cs#L96
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/ProfileOptSetup.cs#L16
Unreachable code detected
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Toolshed/TypeParsers/SessionTypeParser.cs#L46
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Toolshed/TypeParsers/SessionTypeParser.cs#L57
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Toolshed/TypeParsers/QuantityTypeParser.cs#L67
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/MarkupNode.cs#L10
'MarkupNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Console/IConsoleShell.cs#L62
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/ViewVariables/ViewVariablesTypeHandler.cs#L213
'Logger.ErrorS(string, Exception, string, params object?[])' is obsolete: 'Use ISawmill.Error'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/ComponentTrees/ComponentTreeSystem.cs#L291
'IMapManager.GetMapEntityId(MapId)' is obsolete: 'Use TryGetMap'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L590
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L660
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L662
'TransformComponent.AttachToGridOrMap()' is obsolete: 'Use the system's method instead.'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L671
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/ZStd.cs#L288
The '&' operator should not be used on parameters or local variables in async methods.
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/ZStd.cs#L288
The '&' operator should not be used on parameters or local variables in async methods.
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/MarkupNode.cs#L10
'MarkupNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Console/IConsoleShell.cs#L62
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/ViewVariables/ViewVariablesTypeHandler.cs#L213
'Logger.ErrorS(string, Exception, string, params object?[])' is obsolete: 'Use ISawmill.Error'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/CPUJob/JobQueues/Job.cs#L187
'Logger.ErrorS(string, string, params object?[])' is obsolete: 'Use ISawmill.Error'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/ContainerManagerComponent.cs#L33
'Component.Owner' is obsolete: 'Update your API to allow accessing Owner through other means'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/ContainerSlot.cs#L75
'Logger.Warning(string)' is obsolete: 'Use ISawmill.Warning'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/ComponentTrees/ComponentTreeSystem.cs#L291
'IMapManager.GetMapEntityId(MapId)' is obsolete: 'Use TryGetMap'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L590
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L660
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L662
'TransformComponent.AttachToGridOrMap()' is obsolete: 'Use the system's method instead.'
|