-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify_eigrp_interfaces_peers API to verify.py ios/iosxe eigrp protocol #171
Conversation
add test_api_verify_eigrp_interfaces_peers.py
…verify_eigrp_interfaces_peers/test
add mock_data.yaml
…verify_eigrp_interfaces_peers/mock_data/iosxe/test
Delete this to add a new containing new API verify_eigrp_interfaces_peers
Add a new verify.py file containing a new API verify_eigrp_interfaces_peers
Add changelog_add_verify_eigrp_interfaces_peers_apis
Hi @lsheikal @ThomasJRyan I added a PR for Cisco pyATS API for EIGRP verify.py. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! It's a little heavy handed on some Python quirks, but functionally I don't see anything wrong with it
Hi @ThomasJRyan thank you for reviewing and accepting my PR! It is not quirks but innovation |
We'll have to agree to disagree on that one 😂 Thank you again for the contribution! |
Hello,
I added verify_eigrp_interfaces_peers API to verify.py (my previous contribution) for ios/iosxe eigrp protocol.
I added the tests folder verify_eigrp_interfaces_peers at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/verify
I added the changelog_add_verify_eigrp_interfaces_peers_apis_202417071905 file at pkgs/sdk-pkg/changelog folder
Thank you for reviewing my contribution