[RPP] Support non-navigations in layout shift details track

Bug: 366049346, 329735547 Change-Id: I7278434ecc4d5177b67efb2762b9bd4d16e1c79e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5878779 Auto-Submit: Connor Clark <[email protected]> Commit-Queue: Adriana Ixba <[email protected]> Reviewed-by: Adriana Ixba <[email protected]>
ChromeDevTools · Sep 20, 2024 · a340d7a · a340d7a
1 parent e049797
commit a340d7a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/front_end/panels/timeline/components/LayoutShiftDetails.test.ts b/front_end/panels/timeline/components/LayoutShiftDetails.test.ts
@@ -16,7 +16,7 @@ describeWithMockConnection('LayoutShiftDetails', () => {
     assert.isNotNull(shiftEvent);
 
     const details = new TimelineComponents.LayoutShiftDetails.LayoutShiftDetails();
-    await details.setData(shiftEvent, insights, traceData, false);
+    details.setData(shiftEvent, insights, traceData, false);
 
     assert.isNotNull(details.shadowRoot);
     const decorativeChip = details.shadowRoot.querySelector('.timeline-details-chip-decorative-title');

diff --git a/front_end/panels/timeline/components/LayoutShiftDetails.ts b/front_end/panels/timeline/components/LayoutShiftDetails.ts
@@ -179,7 +179,8 @@ export class LayoutShiftDetails extends HTMLElement {
     }
 
     const ts = TraceEngine.Types.Timing.MicroSeconds(layoutShift.ts - traceEngineData.Meta.traceBounds.min);
-    const clsInsight = traceInsightsData.get(layoutShift.args.data?.navigationId ?? '')?.data.CumulativeLayoutShift;
+    const insightsId = layoutShift.args.data?.navigationId ?? TraceEngine.Insights.Types.NO_NAVIGATION;
+    const clsInsight = traceInsightsData.get(insightsId)?.data.CumulativeLayoutShift;
     if (clsInsight instanceof Error) {
       return null;
     }