[Lighthouse] Prevent flake when switching to Lighthouse tab in tests

Bug: 388183157 Change-Id: I997a4c35821bbe003fffebee3774ad96909c7e6f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6147555 Commit-Queue: Connor Clark <[email protected]> Reviewed-by: Connor Clark <[email protected]> Auto-Submit: Adam Raine <[email protected]>
ChromeDevTools · Jan 7, 2025 · 972ab82 · 972ab82
1 parent 3f3b139
commit 972ab82
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/test/e2e/helpers/lighthouse-helpers.ts b/test/e2e/helpers/lighthouse-helpers.ts
@@ -27,8 +27,16 @@ export async function navigateToLighthouseTab(path?: string): Promise<ElementHan
     lighthouseTabButton = await waitForElementWithTextContent('Lighthouse');
   }
 
-  await lighthouseTabButton.click();
-  await waitFor('.view-container > .lighthouse');
+  // TODO(b/388183157): Investigate why a single click doesn't open the tab properly sometimes
+  const interval = setInterval(() => {
+    void lighthouseTabButton.click();
+  }, 500);
+
+  try {
+    await waitFor('.view-container > .lighthouse');
+  } finally {
+    clearInterval(interval);
+  }
 
   const {target, frontend} = getBrowserAndPages();
   if (path) {

diff --git a/test/e2e/lighthouse/navigation_test.ts b/test/e2e/lighthouse/navigation_test.ts
@@ -66,8 +66,8 @@ describe('Navigation', function() {
       console.error(consoleLog.join('\n'));
     }
   });
-  // Flaky
-  it.skip('[crbug.com/388183157] successfully returns a Lighthouse report', async () => {
+
+  it('successfully returns a Lighthouse report', async () => {
     await navigateToLighthouseTab('lighthouse/hello.html');
     await registerServiceWorker();