Skip to content

Commit

Permalink
Manually roll puppeteer-core
Browse files Browse the repository at this point in the history
Manual changes are in PuppeteerConnection, which removes the `product`
param when calling `Browser._create`

Bug: none
Change-Id: I90c86874785c19be5cde4e60b158511327f14b22
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6167551
Auto-Submit: Andres Olivares <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Andres Olivares <[email protected]>
  • Loading branch information
and-oli authored and Devtools-frontend LUCI CQ committed Jan 13, 2025
1 parent 2ec355e commit 5c7ee90
Show file tree
Hide file tree
Showing 169 changed files with 1,528 additions and 2,606 deletions.
3 changes: 1 addition & 2 deletions config/gni/devtools_grd_files.gni
Original file line number Diff line number Diff line change
Expand Up @@ -2022,7 +2022,6 @@ grd_files_debug_sources = [
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/BrowserContext.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/CDPSession.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/CdpPreloadScript.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/ChromeTargetManager.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/Connection.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/Coverage.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/DeviceRequestPrompt.js",
Expand All @@ -2031,7 +2030,6 @@ grd_files_debug_sources = [
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/EmulationManager.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/ExecutionContext.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/ExtensionTransport.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/FirefoxTargetManager.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/Frame.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/FrameManager.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/FrameManagerEvents.js",
Expand All @@ -2048,6 +2046,7 @@ grd_files_debug_sources = [
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/Page.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/PredefinedNetworkConditions.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/Target.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/TargetManageEvents.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/TargetManager.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/Tracing.js",
"front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/WebWorker.js",
Expand Down
1 change: 0 additions & 1 deletion front_end/services/puppeteer/PuppeteerConnection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ export class PuppeteerConnectionHelper {
const puppeteerConnection = new PuppeteerConnection('', transport);

const browserPromise = puppeteer.Browser._create(
'chrome',
puppeteerConnection,
[] /* contextIds */,
false /* ignoreHTTPSErrors */,
Expand Down
6 changes: 2 additions & 4 deletions front_end/third_party/puppeteer/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ SOURCES = [
"package/lib/esm/puppeteer/cdp/CDPSession.js",
"package/lib/esm/puppeteer/cdp/CdpPreloadScript.d.ts",
"package/lib/esm/puppeteer/cdp/CdpPreloadScript.js",
"package/lib/esm/puppeteer/cdp/ChromeTargetManager.d.ts",
"package/lib/esm/puppeteer/cdp/ChromeTargetManager.js",
"package/lib/esm/puppeteer/cdp/Connection.d.ts",
"package/lib/esm/puppeteer/cdp/Connection.js",
"package/lib/esm/puppeteer/cdp/Coverage.d.ts",
Expand All @@ -153,8 +151,6 @@ SOURCES = [
"package/lib/esm/puppeteer/cdp/ExecutionContext.js",
"package/lib/esm/puppeteer/cdp/ExtensionTransport.d.ts",
"package/lib/esm/puppeteer/cdp/ExtensionTransport.js",
"package/lib/esm/puppeteer/cdp/FirefoxTargetManager.d.ts",
"package/lib/esm/puppeteer/cdp/FirefoxTargetManager.js",
"package/lib/esm/puppeteer/cdp/Frame.d.ts",
"package/lib/esm/puppeteer/cdp/Frame.js",
"package/lib/esm/puppeteer/cdp/FrameManager.d.ts",
Expand Down Expand Up @@ -187,6 +183,8 @@ SOURCES = [
"package/lib/esm/puppeteer/cdp/PredefinedNetworkConditions.js",
"package/lib/esm/puppeteer/cdp/Target.d.ts",
"package/lib/esm/puppeteer/cdp/Target.js",
"package/lib/esm/puppeteer/cdp/TargetManageEvents.d.ts",
"package/lib/esm/puppeteer/cdp/TargetManageEvents.js",
"package/lib/esm/puppeteer/cdp/TargetManager.d.ts",
"package/lib/esm/puppeteer/cdp/TargetManager.js",
"package/lib/esm/puppeteer/cdp/Tracing.d.ts",
Expand Down
4 changes: 2 additions & 2 deletions front_end/third_party/puppeteer/README.chromium
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
Name: Puppeteer Core
Short Name: Puppeteer Core
URL: https://github.com/puppeteer/puppeteer/tree/main/packages/puppeteer-core
Version: 23.11.1
Version: 24.0.0
License: Apache-2.0
License File: LICENSE
Revision: 893f5eccbab8e983f8765a3e4ef936bdf99cb35e
Revision: 0b006175eea0c58957715b2c1cd7e56aec5170f1
Security Critical: no
Shipped: yes

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5c7ee90

Please sign in to comment.