Skip to content

Commit

Permalink
[AI settings] Update disclaimer bullet points
Browse files Browse the repository at this point in the history
Screenshots: https://imgur.com/a/s8eXtu0

Bug: 372196790, 381375534
Change-Id: I8eb7cdbe2bf9dc014abc369bb5836840b13a2c66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6170691
Auto-Submit: Wolfgang Beyer <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
  • Loading branch information
wolfib authored and Devtools-frontend LUCI CQ committed Jan 13, 2025
1 parent e93ae5e commit 40f57f8
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
7 changes: 3 additions & 4 deletions front_end/panels/settings/AISettingsTab.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,7 @@ describeWithEnvironment('AISettingsTab', () => {
assert.strictEqual(
disclaimers[3].textContent,
'These features send relevant data to Google. Google collects this data and feedback to improve its products and services with the help of human reviewers. Avoid sharing sensitive or personal information.');
assert.strictEqual(
disclaimers[7].textContent, 'Depending on your region, Google may refrain from data collection.');
assert.strictEqual(disclaimers[5].textContent, 'Depending on your region, Google may refrain from data collection');

const settingCards = view.shadowRoot.querySelectorAll('.setting-card h2');
const settingNames = Array.from(settingCards).map(element => element.textContent);
Expand Down Expand Up @@ -111,10 +110,10 @@ describeWithEnvironment('AISettingsTab', () => {
const disclaimers = view.shadowRoot.querySelectorAll('.shared-disclaimer .disclaimer-list div');
assert.strictEqual(
disclaimers[3].textContent,
'Usage data will be retained for up to 18 months and stored in such a way that Google can’t tell who provided it.');
'Your content will not be used by human reviewers to improve AI. Your organization may change these settings at any time.');
assert.strictEqual(
disclaimers[5].textContent,
'Your content will not be used by human reviewers to improve AI. Your organization may change these settings at any time. Depending on your Google account management and/or region, Google may refrain from data collection.');
'Depending on your Google account management and/or region, Google may refrain from data collection');
stub.restore();
});

Expand Down
17 changes: 10 additions & 7 deletions front_end/panels/settings/AISettingsTab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const UIStrings = {
*@description Text describing a fact to consider when using AI features
*/
experimentalFeatures:
'These features are experimental. They use generative AI and may provide inaccurate or offensive information that doesn’t represent Google’s views.',
'These features use generative AI and may provide inaccurate or offensive information that doesn’t represent Google’s views',
/**
*@description Text describing a fact to consider when using AI features
*/
Expand All @@ -42,17 +42,18 @@ const UIStrings = {
/**
*@description Text describing a fact to consider when using AI features
*/
retainData:
'Usage data will be retained for up to 18 months and stored in such a way that Google can’t tell who provided it.',
sendsDataToGoogleNoLogging:
'Your content will not be used by human reviewers to improve AI. Your organization may change these settings at any time.',

/**
*@description Text describing a fact to consider when using AI features
*/
dataCollection: 'Depending on your region, Google may refrain from data collection.',
dataCollection: 'Depending on your region, Google may refrain from data collection',
/**
*@description Text describing a fact to consider when using AI features
*/
dataCollectionNoLogging:
'Your content will not be used by human reviewers to improve AI. Your organization may change these settings at any time. Depending on your Google account management and/or region, Google may refrain from data collection.',
'Depending on your Google account management and/or region, Google may refrain from data collection',
/**
*@description Text describing the 'Console Insights' feature
*/
Expand Down Expand Up @@ -336,8 +337,10 @@ export class AISettingsTab extends LegacyWrapper.LegacyWrapper.WrappableComponen

const bulletPoints = [
{icon: 'psychiatry', text: i18nString(UIStrings.experimentalFeatures)},
...noLogging ? [] : [{icon: 'google', text: i18nString(UIStrings.sendsDataToGoogle)}],
{icon: 'calendar-today', text: i18nString(UIStrings.retainData)},
{
icon: 'google',
text: noLogging ? i18nString(UIStrings.sendsDataToGoogleNoLogging) : i18nString(UIStrings.sendsDataToGoogle),
},
{
icon: 'corporate-fare',
text: noLogging ? i18nString(UIStrings.dataCollectionNoLogging) : i18nString(UIStrings.dataCollection),
Expand Down

0 comments on commit 40f57f8

Please sign in to comment.