Don't run cron or cache clears on a site with no data

ChromaticHQ · Oct 31, 2024 · fea1674 · fea1674
1 parent 368421d
commit fea1674
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 6 deletions.
diff --git a/src/Robo/Plugin/Commands/DevelopmentModeCommands.php b/src/Robo/Plugin/Commands/DevelopmentModeCommands.php
@@ -151,7 +151,15 @@ public function databaseRefreshDdev(
         $dbPathProvidedByUser = $dbPath !== '';
 
         if (!$dbPathProvidedByUser) {
-            $dbPath = $this->databaseDownload($io, $siteName);
+            try {
+                $dbPath = $this->databaseDownload($io, $siteName);
+            } catch (TaskException $e) {
+                $resultData = new ResultData(ResultData::EXITCODE_ERROR, $e->getMessage());
+                $io->yell("$siteName: No database configured. Download/import skipped.");
+                // @todo: Should we run a site-install by default? The "common"
+                // site ends up here, but we could change that.
+                return $resultData;
+            }
             // If we don't have a file path string here, the action was
             // cancelled and we should respond with the cancellation.
             if (!is_string($dbPath)) {
@@ -195,7 +203,8 @@ public function databaseRefreshTugboat(ConsoleIO $io): ResultData
             } catch (TaskException $e) {
                 $io->yell("$siteName: No database configured. Download/import skipped.");
                 $resultData->append($e->getMessage());
-                // @todo: Should we run a site-install by default?
+                // @todo: Should we run a site-install by default? The "common"
+                // site ends up here, but we could change that.
                 continue;
             }
             if (!is_string($dbPath) || $dbPath === '') {
@@ -316,7 +325,7 @@ protected function devRefreshDrupal(
         $this->frontendDevEnable($io, $siteName, ['yes' => true]);
         /** @var Result|ResultData $result */
         $result = $this->databaseRefreshDdev($io, siteName: $siteName, options: ['db' => $databasePath]);
-        if ($result->wasCancelled()) {
+        if ($result->wasCancelled() || $result->getExitCode() !== ResultData::EXITCODE_OK) {
             return $result;
         }
 

diff --git a/src/Robo/Plugin/Traits/SitesConfigTrait.php b/src/Robo/Plugin/Traits/SitesConfigTrait.php
@@ -26,10 +26,14 @@ trait SitesConfigTrait
      */
     public function getAllSitesConfig(): mixed
     {
-        if (!file_exists($this->sitesConfigFile)) {
-            throw new TaskException($this, "$this->sitesConfigFile not found.");
+        static $allSitesConfig = null;
+        if (is_null($allSitesConfig)) {
+            if (!file_exists($this->sitesConfigFile)) {
+                throw new TaskException($this, "$this->sitesConfigFile not found.");
+            }
+            $allSitesConfig = Yaml::parseFile($this->sitesConfigFile);
         }
-        return Yaml::parseFile($this->sitesConfigFile);
+        return $allSitesConfig;
     }
 
     /**
@@ -108,6 +112,20 @@ public function getSiteConfigItem(string $key, string $siteName = 'default', boo
         return $siteConfig[$key];
     }
 
+    /**
+     * Check if a site has an S3 bucket/has data.
+     *
+     * @throws \Robo\Exception\TaskException
+     */
+    protected function hasData(string $siteName = 'default'): bool
+    {
+        $db = $this->getSiteConfigItem(
+            key: 'database_s3_bucket',
+            siteName: $siteName
+        );
+        return (is_string($db) && mb_strlen($db));
+    }
+
     /**
      * Write sites configuration file.
      *