Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to filter out subject (favoriting) with null values. #30

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added the ability to filter out subject (favoriting) with null values. #30

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a3c16c
avoid null user on favoritedby.
arungpisyadi Jul 17, 2021
8d85b26
debug null condition.
arungpisyadi Jul 17, 2021
727956c
debug #2
arungpisyadi Jul 17, 2021
13045f7
debug filtered users (free from null user data)
arungpisyadi Jul 17, 2021
9c9763f
fixed missing semicolumn
arungpisyadi Jul 17, 2021
e191fe0
fixed bug if subject who favorite is null.
arungpisyadi Jul 17, 2021
c93c4b8
check if collection has been rebuilt.
arungpisyadi Jul 17, 2021
27be61f
finalized fixes on null user condition.
arungpisyadi Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Traits/Favoriteable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,14 @@ public function isFavorited($user_id = null)
*/
public function favoritedBy()
{
return $this->favorites()->with('user')->get()->mapWithKeys(function ($item) {
$users = $this->favorites()->with('user')->get();
// dump($users);
$filtered = $users->filter(function($user){
return null !== $user->user;
});
$users = collect($filtered->values()->all());
// dd($users);
return $users->mapWithKeys(function ($item) {
return [$item['user']->id => $item['user']];
});
}
Expand Down