Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to add friends popup #120

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

wesleypayton
Copy link
Collaborator

@wesleypayton wesleypayton commented May 5, 2024

Problem

We want an X button on the Add Friends popup to match style with our other popups.
We also want to add a hashtag graphic before the email entry for styling.

Definition of Done

  • Add Friends popup has an X button at the top right corner that closes the popup
  • The email entry has a hashtag icon before it

Solution

  • Converted Add Friends popup to use Grid layout rather than VerticalStackLayout
  • Added X button that closes the popup similar in style to the mindfulness tip popup
  • Add Friends popup can only be closed using the X button
  • Added hashtag icon before the email entry
  • Changed text on send button to be circle arrow icon to conserve space

image

How was this tested?

Manually tested on android emulator. Needs to be tested on android test device.

Copy link
Owner

@ChrispyPeaches ChrispyPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@iggy808 iggy808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ggwp

@wesleypayton wesleypayton merged commit 205de94 into develop May 8, 2024
4 checks passed
@wesleypayton wesleypayton deleted the changes-to-add-friends-popup branch May 8, 2024 03:00
@ChrispyPeaches ChrispyPeaches mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants