Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Various hotfixes and improvements #119

Merged
merged 12 commits into from
May 8, 2024

Conversation

ChrispyPeaches
Copy link
Owner

  • Update app metadata, icons, and splash screen for compatibility with circle android app icons
  • Remove secure files
  • Disallow concurrent execution of login or skip button triggered logic
  • Move logout button to settings page, refactor settings page, and add about popup with dev email
  • Refactor use of authentication service application-wide to ensure all fields that are created outside of the current user field are being always used instead of ones inside of the current user field (for binding purposes)
    • This was necessary for adding the Balance field to auth service and I did the same for email since I was already working on it
  • Add balance display to timer page
    • Created a new custom view called BalanceDisplay to standardize the displaying of the balance field on the shop and timer pages

@ChrispyPeaches ChrispyPeaches changed the title Update app metadata [Hotfix] Various hotfixes and improvements May 3, 2024
wesleypayton
wesleypayton previously approved these changes May 5, 2024
Copy link
Collaborator

@wesleypayton wesleypayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM 💯

Copy link
Collaborator

@wesleypayton wesleypayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM! Nice work on fixing that login issue

@ChrispyPeaches ChrispyPeaches requested review from iggy808, JohnParks032 and wesleypayton and removed request for wesleypayton May 7, 2024 16:58
Copy link
Collaborator

@iggy808 iggy808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ggwp

@iggy808 iggy808 merged commit 7a87492 into develop May 8, 2024
4 checks passed
@ChrispyPeaches ChrispyPeaches mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants