Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Shop UI #118

Merged
merged 4 commits into from
May 8, 2024
Merged

Refactor Shop UI #118

merged 4 commits into from
May 8, 2024

Conversation

iggy808
Copy link
Collaborator

@iggy808 iggy808 commented May 1, 2024

Problem

On smaller screensizes, the shop item carousels leaked into the tab bar.

Definition of Done

  • The shop screen functions appropriately on different sized screens.

Solution

  • Convert the stack layout used by the shopscreen into a grid layout for dynamic styling.

How was this tested?

  • Manually on the Pixel 5 and Nexus 6 emulators. I still need to test this on a live device.

@iggy808 iggy808 changed the title Rework shop page to have grid layout vs. stack layout Refactor Shop UI May 1, 2024
@iggy808 iggy808 marked this pull request as draft May 1, 2024 03:51
@iggy808 iggy808 marked this pull request as ready for review May 5, 2024 22:23
ChrispyPeaches
ChrispyPeaches approved these changes May 6, 2024
View reviewed changes
Copy link
Owner

@ChrispyPeaches ChrispyPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

wesleypayton
wesleypayton approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@wesleypayton wesleypayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We loooove grids

@wesleypayton wesleypayton merged commit b990919 into develop May 8, 2024
4 checks passed
@wesleypayton wesleypayton deleted the Refactor-Shop-UI branch May 8, 2024 03:25
@ChrispyPeaches ChrispyPeaches mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleypayton wesleypayton wesleypayton approved these changes

@ChrispyPeaches ChrispyPeaches ChrispyPeaches approved these changes

@JohnParks032 JohnParks032 Awaiting requested review from JohnParks032

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iggy808 @ChrispyPeaches @wesleypayton