Skip to content

Commit

Permalink
bug fix: lack of defensive copying leads to crash when shell is used …
Browse files Browse the repository at this point in the history
…with mappingproxy
  • Loading branch information
ChrisTimperley committed Jun 1, 2020
1 parent d478510 commit 9521b2b
Showing 3 changed files with 9 additions and 2 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
v0.5.1 (2020-06-01)
-------------------

* bug fix: lack of defensive copying in Shell constructor can lead to
crashes due to use of mappingproxy type.


v0.5.0 (2020-05-29)
-------------------

2 changes: 1 addition & 1 deletion src/dockerblade/shell.py
Original file line number Diff line number Diff line change
@@ -85,6 +85,7 @@ class Shell:

def __attrs_post_init__(self) -> None:
object.__setattr__(self, '_sources', tuple(self._sources))
object.__setattr__(self, '_environment', dict(self._environment))

if self._sources:
filesystem = self.container.filesystem()
@@ -312,7 +313,6 @@ def run(self,
args_instrumented = self._instrument(args,
time_limit=time_limit,
kill_after=kill_after)

with Stopwatch() as timer:
retcode, output_bin = docker_container.exec_run(
args_instrumented,
2 changes: 1 addition & 1 deletion src/dockerblade/version.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# -*- coding: utf-8 -*-
__version__ = '0.5.0'
__version__ = '0.5.1'

0 comments on commit 9521b2b

Please sign in to comment.