-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SDC slots #191
Conversation
Tests are failing, but it doesn't seem to be related to SDC. |
@Chi-teck for some reasons I can't explain, the PhpStormMetaTest used to work fine and stops working on Drupal 11.x after commit https://git.drupalcode.org/project/drupal/-/commit/b72df4495eb2f51d5b87b8ad7018fd913c9eb096 The PhpStormMetaTest assertDatabase is looking for the table 'cache_bootstrap' and can't find it. At this point I'm not sure if this is a new bug in D11 or if expected behavior and PhpStormMetaTest should be updated. In any case, this should probably be done in a separate issue. If you have some insights (or maybe @weitzman ?), I can take care of this. |
My bad, I wasn't resetting my git tree correctly before the tests. |
@PierrePaul the tests were broken in 4.x branch as well. @chesn0k has just fixed it and updated this feature branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Fixes #190