Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SDC slots #191

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Add support for SDC slots #191

merged 5 commits into from
Oct 30, 2024

Conversation

PierrePaul
Copy link
Contributor

Fixes #190

@PierrePaul
Copy link
Contributor Author

Tests are failing, but it doesn't seem to be related to SDC.
It seems to be related to PhpStormMetaTest. For some reasons though, it doesn't seem to be failing on other PR (maybe because they are failing at the lint step though). Closed PR from two weeks ago seems fine though.

@PierrePaul
Copy link
Contributor Author

@Chi-teck for some reasons I can't explain, the PhpStormMetaTest used to work fine and stops working on Drupal 11.x after commit https://git.drupalcode.org/project/drupal/-/commit/b72df4495eb2f51d5b87b8ad7018fd913c9eb096

The PhpStormMetaTest assertDatabase is looking for the table 'cache_bootstrap' and can't find it. At this point I'm not sure if this is a new bug in D11 or if expected behavior and PhpStormMetaTest should be updated.

In any case, this should probably be done in a separate issue. If you have some insights (or maybe @weitzman ?), I can take care of this.

@PierrePaul
Copy link
Contributor Author

My bad, I wasn't resetting my git tree correctly before the tests.
The "bad" commit is actually : https://git.drupalcode.org/project/drupal/-/commit/1584d2c9f2e6718034f5c7c051d702a75a5dae62
Which makes a lot more sense than the other one.

@Chi-teck
Copy link
Owner

@PierrePaul the tests were broken in 4.x branch as well. @chesn0k has just fixed it and updated this feature branch.

Copy link
Collaborator

@chesn0k chesn0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@chesn0k chesn0k merged commit 9a5501b into Chi-teck:4.x Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDC generator should support slots
3 participants