Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display non-visible highlight-adjacent nodes #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nathansherburne
Copy link

Visibility Filters currently do not apply to upstream/downstream
adjacent nodes of highlighted nodes. For example, if Private methods are
de-selected in the Visibility Filters, Private methods that call or are
called by a highlighted node will be visible in the graph despite the
"Private functions" checkbox being toggled to off.

This change checks the Visibility Filters before painting
upstream/downstream nodes of highlighted nodes.

Visibility Filters currently do not apply to upstream/downstream
adjacent nodes of highlighted nodes. For example, if Private methods are
de-selected in the Visibility Filters, Private methods that call or are
called by a highlighted node will be visible in the graph despite the
"Private functions" checkbox being toggled to off.

This change checks the Visibility Filters before painting
upstream/downstream nodes of highlighted nodes.
@nathansherburne nathansherburne force-pushed the filter-adjacent-visibility branch from 952fc30 to 2377838 Compare January 20, 2021 20:55
@nathansherburne nathansherburne changed the title Don't display non-visible highlighto-adjacent nodes Don't display non-visible highlight-adjacent nodes Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant