fix: get rid of some more warnings #5672
Merged
+79
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
approved these changes
Oct 27, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1909,7 +1909,7 @@ void Helix::updateChatSettings( | |||
|
|
|||
| void Helix::onFetchChattersSuccess( | |||
| std::shared_ptr<HelixChatters> finalChatters, QString broadcasterID, | |||
| QString moderatorID, int maxChattersToFetch, | |||
| QString moderatorID, size_t maxChattersToFetch, | |||
There was a problem hiding this comment.
warning: the parameter 'moderatorID' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
src/providers/twitch/api/Helix.hpp:1507:
- QString moderatorID, size_t maxChattersToFetch,
+ const QString& moderatorID, size_t maxChattersToFetch,
Suggested change
| QString moderatorID, size_t maxChattersToFetch, | |
| const QString& moderatorID, size_t maxChattersToFetch, |
| @@ -2022,7 +2022,7 @@ | |||
|
|
|||
| void Helix::onFetchModeratorsSuccess( | |||
| std::shared_ptr<std::vector<HelixModerator>> finalModerators, | |||
| QString broadcasterID, int maxModeratorsToFetch, | |||
| QString broadcasterID, size_t maxModeratorsToFetch, | |||
There was a problem hiding this comment.
warning: the parameter 'broadcasterID' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
src/providers/twitch/api/Helix.hpp:1522:
- QString broadcasterID, size_t maxModeratorsToFetch,
+ const QString& broadcasterID, size_t maxModeratorsToFetch,
Suggested change
| QString broadcasterID, size_t maxModeratorsToFetch, | |
| const QString& broadcasterID, size_t maxModeratorsToFetch, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly gets rid of
-Wsign-comparewarnings. These show up when compiling with clang-cl (I know we have them disabled usually).Since Qt 6.8 got a bit more vocal with deprecation warnings, I turned them off for now (only deprecations until 5.15 are enabled). This uses an undocumented
QT_WARN_DEPRECATED_UP_TO. Once we switch to Qt 6, we can bump this.Maybe we could enable
-Wextraand-Wpedantic.