refactor: irc message builder #5663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
MessageBuilderfor IRC messages. IRC messages are now build using a staticmakeIrcMessage. This way,MessageBuilderdoesn't have to keep track of IRC-related state anymore (only the required state). This will make support for EventSub easier (hopefully).While refactoring, I noticed that
MessageBuilder::parseUsernameColordoesn't setMessage::usernameColorif the color is overwritten by user-data. This change can be seen in the updated snapshots.Building IRC messages also includes parsing highlights. The result of that is returned to the caller. Due to this, the
Highlightsbenchmark is obsolete now. All of it is done inside the recent-messages benchmark. In the future, we could add a benchmark specifically forHighlightController::check.MessageBuilder::triggerHighlightscould also be moved to theHighlightControllerin the future.