feat: experiment with a new setting widget builder #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bit more like a builder pattern for adding settings to settings pages i have migrated a few settings, but don't want to do all of them
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -44,9 +45,16 @@ GeneralPageView::GeneralPageView(QWidget *parent) | |||
| }); | |||
| } | |||
|
|
|||
| void GeneralPageView::addWidget(QWidget *widget) | |||
| void GeneralPageView::addWidget(QWidget *widget, QStringList keywords) | |||
There was a problem hiding this comment.
warning: the parameter 'keywords' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
src/widgets/settingspages/GeneralPageView.hpp:98:
- void addWidget(QWidget *widget, QStringList keywords = {});
+ void addWidget(QWidget *widget, const QStringList& keywords = {});
Suggested change
| void GeneralPageView::addWidget(QWidget *widget, QStringList keywords) | |
| void GeneralPageView::addWidget(QWidget *widget, const QStringList& keywords) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will create more widgets per setting, but the goal is to more simply allow us to add various free text to settings that need them.
I don't plan on migrating all settings, but I migrated all the enum dropdowns so I removed that implementation.
It's not really a builder pattern but it tries to be similar to it