-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for watching streams #3222
base: master
Are you sure you want to change the base?
Conversation
There is a mechanism to close the chatterino embed after 30s if it doesn't have a parent window, so that may be going wrong. That should be the issue if it's precisely 30s every time. Which version of windows are you using, and are you using any special settings? |
cds.lpData = json.data(); | ||
|
||
::SendMessage((HWND)handle, WM_COPYDATA, | ||
reinterpret_cast<WPARAM>(handle), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (wParam
) should be handle of the window that is passing the data, as per winapi docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
In addition to the above, when running the StreamView exe directly, it appears to bug out when you switch channels. Then when I try to type in those bugged channels, the chatbox appear to just move down a little more. As shown in the screenshot, it seems this is now permanently bugged after testing the first time: lamo.mp4 |
I tried linking to the webview/webview directly. I also experimented with the QT |
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Allows watching streams from Chatterino. Only works on windows since it uses webview2.
Testing it
StreamView
folder is on the same level aschatterino.exe
.