Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Chargily Pay Package Integration in Laravel #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improve Chargily Pay Package Integration in Laravel #10

wants to merge 4 commits into from

Conversation

AbdenourTadjer33
Copy link

This pull request enhances the integration of the chargily-pay-php package into Laravel applications by adhering to Laravel conventions.

Changes Made

  • Added Service Provider: Added Service Provider ChargilyPayServiceProvider for proper package registration and integration within the Laravel ecosystem.
  • Updated composer.json:
    • Added the Chargily\ChargilyPay\ChargilyPayServiceProvider to the extra.laravel.providers section.
    • Configured sort-packages in the config section.

Testing

  • Tested the new service provider and configuration in an existing Laravel project.

Checklist

  • 🮱 Code changes are well-documented.
  • 🮱 All new and existing tests pass.
  • 🮱 Relevant documentation has been updated.

@AbdenourTadjer33
chore: Update composer.json to enable package sorting and add Chargil…
36d124e 
…yPay service provider

- Enabled package sorting by setting "sort-packages" to true.
- Added ChargilyPayServiceProvider to the Laravel providers list in the "extra" section.
@AbdenourTadjer33
feat: Add ChargilyPay service provider and configuration file
df72de7 
- Introduced ChargilyPayServiceProvider for laravel integration
- Created config file to manage ChargilyPay settings with environment variable support
@AbdenourTadjer33
Update Laravel integration documentation to include configuration set…
1e4ce9f 
…up, environment variables. and controller instructions for the ChargilyPay package.
@AbdenourTadjer33
feat: Add ChargilyPay service provider and configuration file
582b06e 
- Introduced ChargilyPayServiceProvider for laravel integration
- Created config file to manage ChargilyPay settings with environment variable support
@AbdenourTadjer33
Copy link
Author

Hi team, I would appreciate your feedback on the changes made to improve the Chargily Pay package integration. Please let me know if you have any suggestions or concerns.

@Medboubazine
Copy link
Collaborator

Medboubazine commented Nov 9, 2024 •
edited
Loading

Hi team, I would appreciate your feedback on the changes made to improve the Chargily Pay package integration. Please let me know if you have any suggestions or concerns.

Hi,
Thank you for your contribution to improving the library.
I would prefer the Laravel package to be separate from the main library.
It would be even better if you could create a custom package for the Laravel framework based on this library.

@karaOdin @ChargilyDev @AbdenourTadjer33

@AbdenourTadjer33
Copy link
Author

Hi @Medboubazine ,

Thank you for your valuable feedback on my contribution! I understand the advantage of creating a separate Laravel-specific package to integrate Chargily Pay, and I’d be happy to begin working on a dedicated Laravel package that leverages the core Chargily library while maintaining Laravel conventions. For further discussion or any additional input, feel free to reach out to me at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbdenourTadjer33 @Medboubazine