-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update ssz to use non-simd on systems that do not support #7371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to fix
to get more visibility in release notes on this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7371 +/- ##
============================================
- Coverage 48.76% 48.62% -0.15%
============================================
Files 601 603 +2
Lines 40243 40516 +273
Branches 2067 2071 +4
============================================
+ Hits 19626 19700 +74
- Misses 20579 20778 +199
Partials 38 38 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
Motivation
Resolves #7177
Add check for system support of SIMD in
@chainsafe/ssz
and loads correct bindings on the target host.