Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ed25519 sig-bytes size #14

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

conr2d
Copy link
Contributor

@conr2d conr2d commented Jul 7, 2024

Ed25519 signatures are 64 bytes.

@conr2d conr2d requested review from expede, Gozala and oed as code owners July 7, 2024 08:06
Copy link

cla-bot bot commented Jul 7, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, either PR in your signature like so if you have no other disclosures to make or reach out to one more of the codeowners (@bumblefudge @expede @oed) to get yourself added manually.

@oed
Copy link
Collaborator

oed commented Jul 8, 2024

Hi @conr2d is varsig something you are planning to use? Unfortunately we've stopped working on this standard and currently don't have any plans to restart the work.

cc @bumblefudge maybe it's time to archive the repo?

@conr2d
Copy link
Contributor Author

conr2d commented Jul 9, 2024

@oed Thank you for letting me know about the project's discontinuation.

I have a project that uses various DSA and it's crucial to keep the data size small. I think using Multikey would work for cryptographic public keys, but for digital signatures, I haven't found a stabilized specification.

With this project's discontinuation, will the 0x34 varsig entry be removed from multicodec? If it remains, it seems like it would be still suitable for my use case.

@expede
Copy link
Collaborator

expede commented Jul 9, 2024

@conr2d this project is not discontinued. @oed just meant that Ceramic is not using it.

@expede
Copy link
Collaborator

expede commented Jul 9, 2024

@bumblefudge please see the above comment (RE do not archive)

@expede
Copy link
Collaborator

expede commented Jul 9, 2024

@conr2d

Ed25519 signatures are 64 bytes.

Oops indeed! Thanks :)

@expede expede merged commit bd5c69a into ChainAgnostic:main Jul 9, 2024
1 of 2 checks passed
@conr2d conr2d deleted the fix-ed25519 branch July 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants