convert 'X-Cesium-Platform' to the rfc8187 format #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @joseph-kaile, this looks good. I want to hold off merging it until @mramato has a chance to weigh in, though, because it has implications for the ability to parse information from the logs. Can I bug you to implement a simpler version of this in a separate PR that just replaces invalid characters with question marks? That allows us to fix the immediate problem without totally changing the format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
Attempted to follow the format of https://www.rfc-editor.org/rfc/rfc8187. It adds utf-8 to the beginning, replaces spaces with %20 (assumes the spaces are unquoted), and replaces unicode character with the hex format.