Feature/ner mappings #1739
Merged
Feature/ner mappings #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, I think the way you're doing it is fine, but the function you're looking for this this one: I-analyzer/backend/es/es_alias.py Line 54 in 09317cd |
…gitalHumanities/I-analyzer into feature/ner-mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1724 : this branch removes the functionality relying on the presence of
annotated_textmappings. I verified this works on the test server. One thing I'm not too happy with is the wayfind_named_entity_fieldsfunction now goes fromcorpus.es_indexto the actual (versioned) index name. Will continue with this tomorrow, as I'm sure we already have a proper way to derive this information in place.Another TO DO: drop the
Annotated Textplugin in Docker.