Feature/corpus doc order #1626
Merged
Feature/corpus doc order #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukavdplas
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Looks good!
I think the more proper solution would be to make the underlying values of the type field integers instead of strings, but I agree that efficiency isn't relevant given the small number of objects.
Looks like 2 unrelated files snuck into your branch, but I see no issue with merging them.
Comment on lines
-455
to
+456
| LICENSE = ('license', 'Licence') | ||
| LICENSE = ('license', 'License') |
Comment on lines
5
to
+13
| import * as _ from 'lodash'; | ||
| import { Router } from '@angular/router'; | ||
| import { HttpErrorResponse } from '@angular/common/http'; | ||
| import { Subject } from 'rxjs'; | ||
|
|
||
| @Component({ | ||
| selector: 'ia-create-definition', | ||
| templateUrl: './create-definition.component.html', | ||
| styleUrls: ['./create-definition.component.scss'] | ||
| styleUrls: ['./create-definition.component.scss'], |
I considered making the types a proper Enum, but that would make adding more documentation pages between existing ones more difficult (read: requiring data migrations). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1607
Takes the choices of the
typefield in the backend as canonical order, to make it easy to extend the types at a later stages.I realize using
.index()as key is not the most efficient way to sort, but it's a small amount of pages.