Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use params.get instead of lodash get #1621

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Conversation

BeritJanssen
Copy link
Contributor

Close #1297.

@BeritJanssen BeritJanssen requested a review from lukavdplas July 4, 2024 13:15
@JeltevanBoheemen
Copy link
Contributor

Good to see this fixes it. Any idea why? :)

@BeritJanssen
Copy link
Contributor Author

Yes: params is not a simple object, but a Params object, which has a method .get. Otherwise, we'd need to do _.get(params.params, ...), but since we already have a default for this.neighbours, this is not necessary.

@lukavdplas
Copy link
Contributor

Yes: params is not a simple object, but a Params object, which has a method .get. Otherwise, we'd need to do _.get(params.params, ...), but since we already have a default for this.neighbours, this is not necessary.

Did you test this? This description sounds like ParamMap, not Params.

@BeritJanssen
Copy link
Contributor Author

Yes, indeed, the object that gets passed in is a ParamMap (in ParamDirective: this.route.queryParamMap.subscribe...). I went ahead and corrected the typing.

@JeltevanBoheemen JeltevanBoheemen merged commit e83ce0b into develop Jul 5, 2024
2 checks passed
@JeltevanBoheemen JeltevanBoheemen deleted the bugfix/nn-reset branch July 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nearest neighbours: neighbours input resets on confirm
3 participants