Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][ICA][ENG-6992] Add logs for curator management behavior #10935

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Jan 21, 2025

Purpose

This is to add logging indications for when a curator is added or removed from a project.

Changes

  • make logs indicate if you've added or removed a curator by adding CURATOR_ADDED and CURATOR_REMOVED` logging actions
  • because this touched tests hidden away in the huge test_views.py I decided to do some house cleaning and split that up into a few smaller files < 1000 lines.

Screenshot 2025-01-21 at 1 10 39 PM

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-6992

@Johnetordoff Johnetordoff changed the title [WIP][ENG-6992] Add logs for curator management behavior [WIP][ICA][ENG-6992] Add logs for curator management behavior Jan 21, 2025
@Johnetordoff Johnetordoff marked this pull request as ready for review January 21, 2025 19:14
@Johnetordoff Johnetordoff changed the base branch from feature/institutional_access to develop January 23, 2025 14:33
 into alert-admins-of-changed-affillations

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Update CHANGELOG, bump version
  [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922)

# Conflicts:
#	osf/models/mixins.py
 into log-add-curator

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Update CHANGELOG, bump version
  [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922)
…urator-with-correct-permissions

[ICA][ENG-6995] Add Curator with Correct Permissions
…ite-resubmits-for-IAC

[IAC][ENG-6998] Infinite Resubmits For IAC
…penScience/osf.io into ica-fix-send-email-without-custom-text

* 'feature/b-and-i-25-01' of https://github.com/CenterForOpenScience/osf.io:
  Use previously-fetched guid__id
  Update CHANGELOG, bump version
  [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922)
  fix issue with requested permissions not being passed into state machine add contributor method
  no message
  add resubmit/update ability for node requests

# Conflicts:
#	api_tests/requests/views/test_node_request_institutional_access.py
…ix-send-email-without-custom-text

[ENG-6994][ICA] Send email without user generated text
…-admins-of-changed-affillations

[ENG-7004] Add notification for admins when Project affiliations changed
 into log-add-curator

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  fix for metrics
  Use previously-fetched guid__id
…penScience/osf.io into log-add-curator

* 'feature/b-and-i-25-01' of https://github.com/CenterForOpenScience/osf.io:
  update email copy
  refactor tests an clean-up tests, split up cases stop pointless reloads
  send email notifications when changing affiliations, split up test files
  fix issue with requested permissions not being passed into state machine add contributor method
  allow email to be sent with placeholder text for project requests and move language from settings to language module
  no message
  add resubmit/update ability for node requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant