-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][ICA][ENG-6992] Add logs for curator management behavior #10935
Open
Johnetordoff
wants to merge
20
commits into
CenterForOpenScience:develop
Choose a base branch
from
Johnetordoff:log-add-curator
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP][ICA][ENG-6992] Add logs for curator management behavior #10935
Johnetordoff
wants to merge
20
commits into
CenterForOpenScience:develop
from
Johnetordoff:log-add-curator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
log-add-curator
branch
from
January 21, 2025 19:08
96c0762
to
66617d4
Compare
Johnetordoff
changed the title
[WIP][ENG-6992] Add logs for curator management behavior
[WIP][ICA][ENG-6992] Add logs for curator management behavior
Jan 21, 2025
…d move language from settings to language module
…ine add contributor method
Johnetordoff
changed the base branch from
feature/institutional_access
to
develop
January 23, 2025 14:33
Johnetordoff
force-pushed
the
log-add-curator
branch
from
January 24, 2025 18:57
66617d4
to
6849d60
Compare
Johnetordoff
force-pushed
the
log-add-curator
branch
from
January 24, 2025 19:01
6849d60
to
9c2e2b8
Compare
Johnetordoff
force-pushed
the
log-add-curator
branch
from
January 27, 2025 16:10
b82707e
to
3346b07
Compare
…es added f-string and split-up files
Johnetordoff
force-pushed
the
log-add-curator
branch
from
January 27, 2025 16:12
3346b07
to
ebeedee
Compare
into alert-admins-of-changed-affillations * 'develop' of https://github.com/CenterForOpenScience/osf.io: Update CHANGELOG, bump version [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922) # Conflicts: # osf/models/mixins.py
into log-add-curator * 'develop' of https://github.com/CenterForOpenScience/osf.io: Update CHANGELOG, bump version [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922)
Johnetordoff
force-pushed
the
log-add-curator
branch
from
January 28, 2025 15:09
9c553d5
to
3d38500
Compare
…urator-with-correct-permissions [ICA][ENG-6995] Add Curator with Correct Permissions
…ite-resubmits-for-IAC [IAC][ENG-6998] Infinite Resubmits For IAC
…penScience/osf.io into ica-fix-send-email-without-custom-text * 'feature/b-and-i-25-01' of https://github.com/CenterForOpenScience/osf.io: Use previously-fetched guid__id Update CHANGELOG, bump version [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922) fix issue with requested permissions not being passed into state machine add contributor method no message add resubmit/update ability for node requests # Conflicts: # api_tests/requests/views/test_node_request_institutional_access.py
…ix-send-email-without-custom-text [ENG-6994][ICA] Send email without user generated text
…-admins-of-changed-affillations [ENG-7004] Add notification for admins when Project affiliations changed
Johnetordoff
force-pushed
the
log-add-curator
branch
from
January 29, 2025 22:09
c49207e
to
583d9c2
Compare
into log-add-curator * 'develop' of https://github.com/CenterForOpenScience/osf.io: fix for metrics Use previously-fetched guid__id
…penScience/osf.io into log-add-curator * 'feature/b-and-i-25-01' of https://github.com/CenterForOpenScience/osf.io: update email copy refactor tests an clean-up tests, split up cases stop pointless reloads send email notifications when changing affiliations, split up test files fix issue with requested permissions not being passed into state machine add contributor method allow email to be sent with placeholder text for project requests and move language from settings to language module no message add resubmit/update ability for node requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is to add logging indications for when a curator is added or removed from a project.
Changes
CURATOR_ADDED
and CURATOR_REMOVED` logging actionstest_views.py
I decided to do some house cleaning and split that up into a few smaller files < 1000 lines.QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-6992