Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6706] Preprints DOI Versioning Project PR - BE #10922

Merged
merged 322 commits into from
Jan 27, 2025
Merged

[ENG-6706] Preprints DOI Versioning Project PR - BE #10922

merged 322 commits into from
Jan 27, 2025

Conversation

cslzchen
Copy link
Collaborator

@cslzchen cslzchen commented Jan 16, 2025 •
edited
Loading

Purpose

  • This pull request implements the backend features for the Preprints DOI Versioning Project.
  • The main goal is to enable preprints versioning, ensuring that each version of a preprint can be uniquely identified and managed.

Changes

  • Added new views and endpoints for handling versioned preprints.
  • Modified permissions to accommodate new versioned preprints features.
  • Added/Updated URL patterns for the versioned preprints.
  • Updated the Preprint model to include fields and methods for DOI versioning.
  • Added a script to populate existing preprints with initial versioned preprint data.
  • Added/Updated unit tests to ensure the correctness of the DOI versioning implementation.

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-6706

Ostap-Zherebetskyi and others added 30 commits December 9, 2024 13:38
@Ostap-Zherebetskyi
updated ReviewableMixin for the versioned preprints
608825d
@Ostap-Zherebetskyi
versioned preprints refactor
4708caf
@Vlad0n20
Add new checks for version guid tests
e876fb0
@Ostap-Zherebetskyi
versioned preprints refactor
b395aaa
@Ostap-Zherebetskyi
removed unused parameter
4a4605c
@Ostap-Zherebetskyi
update preprint load method
b3fc503
@Ostap-Zherebetskyi
updated split_guid method
7778524
@cslzchen
Merge pull request #10828 from Ostap-Zherebetskyi/feature/rejected_pr…
4a64cc1 
…eprints_update

[ENG-6644][ENG-6680] Rejected version number and GUID referent
@cslzchen
Merge pull request #10813 from Vlad0n20/fix/ENG-6558
4a7aa35 
[ENG-6558] Fix failed tests for new Versioned GUID change - Part 1
@Ostap-Zherebetskyi
Merge remote-tracking branch 'upstream/feature/preprints-doi-versioni…
c507291 
…ng' into fix/refactor_versioned_preprint
@bodintsov
refactored code, removed useless
fec70d2
@bodintsov
removed litter
b947839
@Ostap-Zherebetskyi
versioned preprints refactor
a49ec3c
@Ostap-Zherebetskyi
versioned preprints refactor
46a4a2a
@cslzchen
Merge pull request #10834 from Ostap-Zherebetskyi/fix/refactor_versio…
6dc0b3c 
…ned_preprint

[ENG-6692] Versioned preprints refactor
@cslzchen
Merge pull request #10829 from bodintsov/feature/update_sitemap_gener…
fc70e02 
…ator

[ENG-6477] Feature/update sitemap generator
@Vlad0n20
Fix most api_2 tests
a0b891d
@Vlad0n20
Fix preprint admin tests. The issue was that in WithdrawalRequestMixi…
ba86b08 
…n.get_object couldn't find versioned guid
@Vlad0n20
Update API for version guid and remove test fixes
e350bd0
@Vlad0n20
Remove useless code
a9c5d8d
@cslzchen
Merge pull request #10830 from Vlad0n20/fix/ENG-6547
c9c85e1 
[ENG-6647] Fix api_2 tests
@bodintsov
fixed 500 eror on invalid guid
d551677
@bodintsov
added tests for versioned DOI and crossref metadata
56d2d4e
@Ostap-Zherebetskyi
updated PreprintOldVersionsImmutableMixin
0888f31
@bodintsov
added unique constraint to GuidVersionsThrough
80267ff
@Vlad0n20
Fix website tests
7008790
@cslzchen
Merge pull request #10839 from bodintsov/feature/improve_version_inel…
fcc61de 
…igeble_objects

[ENG-6679] Feature/improve version ineligeble objects
@cslzchen
Merge pull request #10846 from Ostap-Zherebetskyi/fix/update_Preprint…
66aea3f 
…OldVersionsImmutableMixin

[ENG-6720] Fixed PreprintOldVersionsImmutableMixin
@cslzchen
Merge pull request #10848 from bodintsov/feature/add_uniqueness_to_gu…
c06e1eb 
…id_versions_through

[ENG-6702] Added unique constraint to GuidVersionsThrough
@cslzchen
Simplify resolve guid
70ca5eb
mfraezz
mfraezz approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple open questions, but otherwise LGTM. Should be RTM when those (and the previously-discussed API relationship stuff, and CrossRef API issue) are resolved.

Pass complete :octocat:

api/base/utils.py Outdated Show resolved Hide resolved
api_tests/nodes/views/test_node_preprints.py Outdated Show resolved Hide resolved
api_tests/preprints/views/test_preprint_versions.py Outdated Show resolved Hide resolved
osf/models/preprint.py Outdated Show resolved Hide resolved
@cslzchen
Copy link
Collaborator Author

The failed test passed locally, might be a random hiccup, hopefully next merge will fix it.

cslzchen and others added 12 commits January 24, 2025 10:14
@cslzchen
Merge pull request #10945 from bodintsov/feature/preprints-dont-incul…
58dbd04 
…de-rejected-versions-to-crossref

[ENG-6989] Don`t include rejected preprints to CrossRef metadata
@cslzchen
Revert "Merge pull request #10917 from cslzchen/feature/fix-update-se…
95ace15 
…arch-for-subjects"

This reverts commit 2d8c54e, reversing
changes made to 8f71b73.
@cslzchen
For preprint, only update share if latest version
cd01c30
@cslzchen
Merge pull request #10946 from cslzchen/feature/revert-deprecated-sha…
0d73565 
…re-fix

[ENG-6706] Revert deprecated share fix
@Vlad0n20 @cslzchen
Add tests for PreprintVersionList view
2e10619
@Vlad0n20 @cslzchen
Add tests for various user permissions for PreprintVersionsListView
379a0bc
@Vlad0n20 @cslzchen
Fix test_preprints_version_permissions_for_admin
8134daf
@Vlad0n20 @cslzchen
Fix comments for pull request
8f64fd5
@Vlad0n20 @cslzchen
Fix failed test
6a501e6
@cslzchen
Fix contributor copy during version creation in preprint factory
c16ae63
@cslzchen
Rework preprint versions list retrieve tests
07e4e2c
@cslzchen
Merge pull request #10926 from Vlad0n20/feature/ENG-6928
3bdca36 
[ENG-6928] Add new tests in `TestPreprintVersionsListRetrieve`
@mfraezz mfraezz merged commit b13312c into develop Jan 27, 2025
17 checks passed
Johnetordoff added a commit to Johnetordoff/osf.io that referenced this pull request Jan 27, 2025
@Johnetordoff
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
9c553d5 
 into log-add-curator

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Update CHANGELOG, bump version
  [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922)
Johnetordoff added a commit to Johnetordoff/osf.io that referenced this pull request Jan 27, 2025
@Johnetordoff
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
a865a6b 
 into alert-admins-of-changed-affillations

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Update CHANGELOG, bump version
  [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922)

# Conflicts:
#	osf/models/mixins.py
Johnetordoff added a commit to Johnetordoff/osf.io that referenced this pull request Jan 28, 2025
@Johnetordoff
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
3d38500 
 into log-add-curator

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Update CHANGELOG, bump version
  [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922)
Johnetordoff added a commit to Johnetordoff/osf.io that referenced this pull request Jan 29, 2025
@Johnetordoff
Merge branch 'feature/b-and-i-25-01' of https://github.com/CenterForO…
2a3b518 
…penScience/osf.io into ica-fix-send-email-without-custom-text

* 'feature/b-and-i-25-01' of https://github.com/CenterForOpenScience/osf.io:
  Use previously-fetched guid__id
  Update CHANGELOG, bump version
  [ENG-6706] Preprints DOI Versioning Project PR - BE (CenterForOpenScience#10922)
  fix issue with requested permissions not being passed into state machine add contributor method
  no message
  add resubmit/update ability for node requests

# Conflicts:
#	api_tests/requests/views/test_node_request_institutional_access.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ostap-Zherebetskyi Ostap-Zherebetskyi Ostap-Zherebetskyi left review comments

@brianjgeiger brianjgeiger brianjgeiger approved these changes

@mfraezz mfraezz mfraezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cslzchen @mfraezz @brianjgeiger @Ostap-Zherebetskyi @Vlad0n20 @bodintsov @sh-andriy