[ENG-6856] Fix migration command to include last preprint #10911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Adding to my comment, if we only need the len(), then an integer, e.g. total_migrated, is good enough. We just increment it with len(vq_list). This should be fast enough which we can output this number in both dry-run and the actual run.
f'Migration has completed successfully! {total_migrated} preprint(s) has/have been migrated.'
cslzchen
requested changes
Jan 14, 2025
cslzchen
approved these changes
Jan 14, 2025
cslzchen
merged commit 8f71b73
into
CenterForOpenScience:feature/preprints-doi-versioning
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix and re-run version migration on staging2
Changes
See diff
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-6856