Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6850] Update old version mix-in check to allow 'rejected' #10901

Conversation

Ostap-Zherebetskyi
Copy link

Purpose

Update old version mix-in check to allow 'rejected'

Changes

See diff

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-6850

@Ostap-Zherebetskyi Ostap-Zherebetskyi marked this pull request as ready for review January 9, 2025 14:44
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and 👍 for the helper / deduplication. I will slightly tweak the format and merge.

osf/models/preprint.py Show resolved Hide resolved
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally and CI looks good.

@cslzchen cslzchen merged commit 608cce3 into CenterForOpenScience:feature/preprints-doi-versioning Jan 9, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants