Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6845][ENG-6864] Fix contributors during preprint version creation #10899

Conversation

cslzchen
Copy link
Collaborator

@cslzchen cslzchen commented Jan 8, 2025

Purpose

Fix the bug where contributors were not completely copied when creating a new version

Changes

  • Use add_contributor instead of modify the through table directly
  • Skipped failed contributors and log errors to Sentry, which doesn't stop the version creation flow

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

@cslzchen cslzchen changed the base branch from develop to feature/preprints-doi-versioning January 8, 2025 22:45
@cslzchen cslzchen changed the title [TBD] Fix contributor add/copy [ENG-6845][ENG-6864] Fix contributors during preprint version creation Jan 9, 2025
@cslzchen cslzchen marked this pull request as ready for review January 9, 2025 02:46
Copy link
Collaborator Author

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally and merging now.

@cslzchen cslzchen merged commit c818d8c into CenterForOpenScience:feature/preprints-doi-versioning Jan 9, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant