[ENG-6849][ENG-6865] Update project overview files widget; auto close window upon oauth completion #10898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlius
changed the title
brianjgeiger
requested changes
Jan 8, 2025
| @@ -54,7 +54,7 @@ def oauth_callback(service_name, auth): | |||
| _forward_to_addon_service('oauth1') | |||
| elif provider._oauth_version == 2: | |||
| _forward_to_addon_service('oauth2') | |||
| return {} | |||
| return {'enable_gv': True} | |||
There was a problem hiding this comment.
Should this return the actual value of the waffle flag?
There was a problem hiding this comment.
It could, but on line 52 it is already checking if the flag is active, so at this point the waffle flag value would always be True.
brianjgeiger
approved these changes
Jan 8, 2025
adlius
merged commit f79087d
into
CenterForOpenScience:feature/gravy_valet_integration
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket