Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6721] Fixed api3_and_osf tests - Part 2 #10894

Merged
merged 7 commits into from
Jan 9, 2025
Merged

[ENG-6721] Fixed api3_and_osf tests - Part 2 #10894

merged 7 commits into from
Jan 9, 2025

Conversation

Ostap-Zherebetskyi
Copy link

@Ostap-Zherebetskyi Ostap-Zherebetskyi commented Jan 7, 2025 •
edited by cslzchen
Loading

Purpose

Fix the rest of the failures in api3_and_osf. Most of them are caused by fixtures assigning fixed guid id.

Changes

See diff

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-6721

@cslzchen cslzchen changed the title [] Fixed some api3_and_osf tests [ENG-6721] Fixed api3_and_osf tests - Part 2 Jan 7, 2025
@Ostap-Zherebetskyi Ostap-Zherebetskyi marked this pull request as ready for review January 8, 2025 16:28
cslzchen
cslzchen reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎆 and I will make the one extra change.

osf/models/base.py Outdated Show resolved Hide resolved
osf_tests/factories.py Show resolved Hide resolved
osf_tests/test_guid.py Outdated Show resolved Hide resolved
@cslzchen cslzchen force-pushed the fix/api3_unit_tests branch 2 times, most recently from 0477f8d to aed8dc0 Compare January 8, 2025 22:37
@cslzchen cslzchen force-pushed the fix/api3_unit_tests branch from e66b9c8 to 418245b Compare January 9, 2025 02:39
@cslzchen cslzchen merged commit 2f3e993 into CenterForOpenScience:feature/preprints-doi-versioning Jan 9, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cslzchen cslzchen cslzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ostap-Zherebetskyi @cslzchen