Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes these two issues related to small screens:
#485
#484
and makes layout changes in News page that may be resolving other things as well.
Changes
News page:
This page was using tables for layouts and wrong nesting of rows and columns
Communities Page
Our board Page
fixed wrong implementation of row-col structure
Side Effects
Shouldn't be any but news page in different layouts should be checked again. There is now a loader on search page. This is required for all images to load before initializing masonry. If this becomes
Screenshot of News Page
Other notes about masonry
Masonry library allows for more options. One of the most important for us is that we can have news items to span 2 or 3 columns. To achieve this add either
.service-box-v1-col2
or.service-box-v1-col3
classes into the existing.service-box-v1
div like so:Masonry can't guarantee bottoms of divs will align in this case so you need to choose where to use this.
Also I'm seeing a lot of wrong use of row and col layout structure in this repo. This reading may help: http://getbootstrap.com/css/#grid