-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6708] IndexStrategy revamp (more than one index per strategy, wow) #840
Merged
aaxelb
merged 35 commits into
CenterForOpenScience:develop
from
aaxelb:feat/multiple-current-indexes
Jan 28, 2025
Merged
[ENG-6708] IndexStrategy revamp (more than one index per strategy, wow) #840
aaxelb
merged 35 commits into
CenterForOpenScience:develop
from
aaxelb:feat/multiple-current-indexes
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaxelb
changed the title
[wip][ENG-6708] IndexStrategy revamp (more than one index per strategy, wow)
[ENG-6708] IndexStrategy revamp (more than one index per strategy, wow)
Jan 23, 2025
felliott
reviewed
Jan 24, 2025
aaxelb
commented
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(comments from group review)
LGTM! We reviewed over zoom, all requested changes made! |
aaxelb
force-pushed
the
feat/multiple-current-indexes
branch
2 times, most recently
from
January 27, 2025 17:01
9cb91f3
to
5b5fc9f
Compare
aaxelb
force-pushed
the
feat/multiple-current-indexes
branch
from
January 28, 2025 15:26
5b5fc9f
to
2d267eb
Compare
Looks good! |
(merging despite the drop in test coverage, intending to follow up with more tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revamp
IndexStrategy
to allow multiple indexes as part of a single coherent strategy -- this better allows common elasticsearch optimizations, like distinct indexes mapped for different kinds of queries(recommend hiding whitespace changes from diff, especially for changes to existing strategies)
simplify existing classes by making them dataclasses (with additional fields) -- an IndexStrategy instance knows its checksum (which may be non-current) and may have multiple SpecificIndex
IndexStrategy
-- each instance represents a current or past version of the strategy, identified by checksumname
field for disambig)indexStrategy
query param)IndexStrategy.SpecificIndex
-- each instance represents a specific index that belongs to a strategy instance and may or may not existremove uniindex methods from IndexStrategy (and friends)
add replacement multiindex methods to IndexStrategy (and friends)
update existing IndexStrategy base methods
update
share.search.index_strategy
public interface (see all)update the "elasticsearch indexes" admin view to list multiple
update
trovesearch_denorm
strategy, split its one index into two ("cards" and "iri_values")ENG-6708