healHistoryTree & External Objects #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…counters a history.next[i] or history.previous that is an external object, which happens when 'importing' into the RERUM DB via an update call on an external URI.
This was
linked to
issues
Aug 10, 2021
Closed
…now it loops over the descendants of the parameter like it is suppose to. Tracks whether or not it is successful and interacts with healHistoryTree() appropriately.
…tory.previous should be the external object URI, history.prime should be root. Right now, it is making history.previous and history.prime the same value in devstore - store import situations, which means data we bring over from dev to prod has no root in prod.
cubap
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit smarter logic for the healHistoryTree() function for when it encounters a history.next[i] or history.previous that is an external object, which happens when 'importing' into the RERUM DB via an update call on an external URI.
I will smooth out Constant.java on master after we merge.