Update TinyDelete.java #287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehabes
reviewed
Sep 3, 2024
| */ | ||
| private boolean validateBearerToken(String token) { | ||
| try { | ||
| FirebaseToken decodedToken = FirebaseAuth.getInstance().verifyIdToken(token); |
There was a problem hiding this comment.
My guess is this is failing because you haven't provided connection parameters to any Firebase instance anywhere.
thehabes
reviewed
Sep 3, 2024
| // Token is valid | ||
| return true; | ||
| } catch (Exception e) { | ||
| // Invalid token |
There was a problem hiding this comment.
Since you are just returning false here, we never see what Exception this is. You'll want to know what specific Exception is happening here, since it has to do with the firebase you want to access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried integrating logic where the delete functionality will either use JSESSION ID or Bearer Token.