feat: expose onJsDialog

include/QCefView.h

@@ -59,6 +59,17 @@ class QCEFVIEW_EXPORT QCefView : public QWidget
   };
   Q_ENUM(CefWindowOpenDisposition)
 
+  /// <summary>
+  /// Represents the CEF javascript dialog type
+  /// </summary>
+  enum CefJsDialogType
+  {
+    JSDIALOGTYPE_ALERT = 0,
+    JSDIALOGTYPE_CONFIRM,
+    JSDIALOGTYPE_PROMPT,
+  };
+  Q_ENUM(CefJsDialogType)
+
 public:
   /// <summary>
   /// Constructs a QCefView instance
@@ -269,6 +280,26 @@ class QCEFVIEW_EXPORT QCefView : public QWidget
   /// <returns>True to enable; otherwise false</returns>
   bool isDragAndDropEnabled() const;
 
+  /// <summary>
+  /// Handles custom JavaScript dialogs
+  /// </summary>
+  /// <param name="originUrl">The URL of the page that triggered the dialog</param>
+  /// <param name="dialogType">The type of the JavaScript dialog (alert, confirm, prompt)</param>
+  /// <param name="messageText">The message to be displayed in the dialog</param>
+  /// <param name="defaultPromptText">The default text for the prompt dialog</param>
+  /// <param name="suppressMessage">Set to true to suppress the dialog</param>
+  /// <param name="callbackResult">A pair containing the result of the dialog and the user input</param>
+  /// <remarks>
+  /// This function is called when a JavaScript dialog is triggered. It allows for custom handling of the dialog,
+  /// including modifying the message, suppressing the dialog, and providing a custom result.
+  /// </remarks>
+  bool onJsDialog(const QString& originUrl,
+                  QCefView::CefJsDialogType dialogType,
+                  const QString& messageText,
+                  const QString& defaultPromptText,
+                  bool& suppressMessage,
+                  QPair<bool, QString>& callbackResult);
+
 signals:
   /// <summary>
   /// Gets called on loading state changed

src/QCefView.cpp

@@ -1,6 +1,8 @@
 #include <QCefView.h>
 
 #pragma region qt_headers
+#include <QInputDialog>
+#include <QMessageBox>
 #include <QPainter>
 #include <QPoint>
 #include <QResizeEvent>
@@ -327,6 +329,40 @@ QCefView::onRequestCloseFromWeb()
   return true;
 }
 
+bool
+QCefView::onJsDialog(const QString& originUrl,
+                     QCefView::CefJsDialogType dialogType,
+                     const QString& messageText,
+                     const QString& defaultPromptText,
+                     bool& suppressMessage,
+                     QPair<bool, QString>& callbackResult)
+{
+  suppressMessage = false;
+
+  QMessageBox::StandardButton button = QMessageBox::NoButton;
+  if (dialogType == QCefView::CefJsDialogType::JSDIALOGTYPE_ALERT) {
+    button = QMessageBox::warning(this, "Alert", messageText);
+    callbackResult.first = true;
+    callbackResult.second = "";
+  } else if (dialogType == QCefView::CefJsDialogType::JSDIALOGTYPE_CONFIRM) {
+    button = QMessageBox::question(this, "Confirm", messageText, QMessageBox::Yes | QMessageBox::No);
+    callbackResult.first = button == QMessageBox::Yes;
+    callbackResult.second = "";
+  } else if (dialogType == QCefView::CefJsDialogType::JSDIALOGTYPE_PROMPT) {
+    bool ok = false;
+    QString text = QInputDialog::getText(this, "Prompt", messageText, QLineEdit::Normal, defaultPromptText, &ok);
+    if (ok) {
+      callbackResult.first = true;
+      callbackResult.second = text;
+    } else {
+      callbackResult.first = false;
+      callbackResult.second = "";
+    }
+  }
+
+  return true;
+}
+
 void
 QCefView::leaveEvent(QEvent* event)
 {

src/details/CCefClientDelegate.h

@@ -94,6 +94,14 @@ class CCefClientDelegate
 #endif
                             CefRefPtr<CefFileDialogCallback> callback) override;
 
+  virtual bool OnJSDialog(CefRefPtr<CefBrowser> browser,
+                          const CefString& origin_url,
+                          CefJSDialogHandler::JSDialogType dialog_type,
+                          const CefString& message_text,
+                          const CefString& default_prompt_text,
+                          CefRefPtr<CefJSDialogCallback> callback,
+                          bool& suppress_message) override;
+
   // DisplayHandler
   virtual void addressChanged(CefRefPtr<CefBrowser>& browser, int64_t frameId, const std::string& url) override;
   virtual void titleChanged(CefRefPtr<CefBrowser>& browser, const std::string& title) override;

src/details/CCefClientDelegate_JSDialogHandler.cpp

@@ -0,0 +1,37 @@
+#include "CCefClientDelegate.h"
+
+#include <QDebug>
+#include <QSharedPointer>
+#include <QThread>
+
+#include "QCefViewPrivate.h"
+#include "utils/CommonUtils.h"
+#include "utils/ValueConvertor.h"
+
+bool
+CCefClientDelegate::OnJSDialog(CefRefPtr<CefBrowser> browser,
+                               const CefString& origin_url,
+                               CefJSDialogHandler::JSDialogType dialog_type,
+                               const CefString& message_text,
+                               const CefString& default_prompt_text,
+                               CefRefPtr<CefJSDialogCallback> callback,
+                               bool& suppress_message)
+
+{
+  bool ret = false;
+
+  QString originUrl = QString::fromStdString(origin_url.ToString());
+  QString messageText = QString::fromStdString(message_text.ToString());
+  QString defaultPromptText = QString::fromStdString(default_prompt_text.ToString());
+
+  Qt::ConnectionType c =
+    pCefViewPrivate_->q_ptr->thread() == QThread::currentThread() ? Qt::DirectConnection : Qt::BlockingQueuedConnection;
+  QMetaObject::invokeMethod(
+    pCefViewPrivate_,
+    [&]() {
+      ret = pCefViewPrivate_->onJsDialog(
+        originUrl, dialog_type, messageText, defaultPromptText, callback, suppress_message);
+    },
+    c);
+  return ret;
+}

src/details/QCefViewPrivate.cpp

@@ -615,6 +615,32 @@ QCefViewPrivate::onCefContextMenuDismissed()
   osr.contextMenuCallback_ = nullptr;
 }
 
+bool
+QCefViewPrivate::onJsDialog(const QString& origin_url,
+                            int dialog_type,
+                            const QString& message_text,
+                            const QString& default_prompt_text,
+                            CefRefPtr<CefJSDialogCallback> callback,
+                            bool& suppress_message)
+{
+  Q_Q(QCefView);
+
+  bool ret = false;
+
+  QPair<bool, QString> callbackResult;
+
+  ret = q->onJsDialog(origin_url,
+                      (QCefView::CefJsDialogType)dialog_type,
+                      message_text,
+                      default_prompt_text,
+                      suppress_message,
+                      callbackResult);
+
+  callback->Continue(callbackResult.first, callbackResult.second.toStdString());
+
+  return ret;
+}
+
 void
 QCefViewPrivate::onFileDialog(CefBrowserHost::FileDialogMode mode,
                               const CefString& title,

src/details/QCefViewPrivate.h

@@ -236,6 +236,13 @@ public slots:
 
   void onContextMenuDestroyed(QObject* obj);
 
+  bool onJsDialog(const QString& origin_url,
+                  int dialog_type,
+                  const QString& message_text,
+                  const QString& default_prompt_text,
+                  CefRefPtr<CefJSDialogCallback> callback,
+                  bool& suppress_message);
+
 signals:
   void updateOsrFrame();