Remove favicon download logic and update interface

CefView · Aug 30, 2023 · a6969ff · a6969ff
1 parent 8604b2c
commit a6969ff
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 48 deletions.
diff --git a/include/CefViewBrowserClientDelegate.h b/include/CefViewBrowserClientDelegate.h
@@ -95,13 +95,6 @@ class CefViewBrowserClientDelegateInterface
 
   virtual void faviconURLChanged(CefRefPtr<CefBrowser> browser, const std::vector<CefString>& icon_urls) = 0;
 
-  virtual bool downloadFavicon()
-  {
-    return true;
-  }
-
-  virtual void faviconChanged(CefRefPtr<CefImage> image) = 0;
-
   virtual bool tooltipMessage(CefRefPtr<CefBrowser>& browser, const std::string& text) = 0;
 
   virtual void fullscreenModeChanged(CefRefPtr<CefBrowser>& browser, bool fullscreen) = 0;

diff --git a/src/CefView/CefBrowserApp/CefViewBrowserClient_DisplayHandler.cpp b/src/CefView/CefBrowserApp/CefViewBrowserClient_DisplayHandler.cpp
@@ -12,8 +12,6 @@
 
 #include <Common/CefViewCoreLog.h>
 
-#include "FaviconDownload/CefViewFaviconDownloadCallback.h"
-
 CefRefPtr<CefDisplayHandler>
 CefViewBrowserClient::GetDisplayHandler()
 {
@@ -48,11 +46,6 @@ CefViewBrowserClient::OnFaviconURLChange(CefRefPtr<CefBrowser> browser, const st
   auto delegate = client_delegate_.lock();
   if (delegate) {
     delegate->faviconURLChanged(browser, icon_urls);
-
-    // download only the first favicon
-    if (!icon_urls.empty() && delegate->downloadFavicon()) {
-      browser->GetHost()->DownloadImage(icon_urls[0], true, 128, false, new CefViewFaviconDownloadCallback(delegate));
-    }
   }
 }
 

diff --git a/src/CefView/CefBrowserApp/FaviconDownload/CefViewFaviconDownloadCallback.h b/src/CefView/CefBrowserApp/FaviconDownload/CefViewFaviconDownloadCallback.h