Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in download-customer-package code #361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alroba
Copy link
Contributor

@alroba alroba commented May 30, 2023

Description of the change

  • Discovered a typo that created a file called 1 every time we execute the tool.
    • Fixed changing 2&>1 to 2>&1.
  • Added the required ":" to the options with parameters in getopt.

Benefits

Avoid creating an extra file when executing the tool.

getopt will work properly with the long options.

Possible drawbacks

There shouldn't be any

Additional information

While debugging this, we found out the following:

  • We create a file for the customer service account that we might be interested in removing at the end of the script.
  • This script won't work on MAC because it uses a different getopt.
    • It will work if we install gnu-getopt over the default getopt.
    • We can create a warning in the documentation (even though we specifically require a Linux machine to execute this script).

@alroba
Copy link
Contributor Author

alroba commented Jun 22, 2023

The getopt vs gnu-getopt in Mac already affected a customer (Indosat): https://carto.zendesk.com/agent/tickets/86771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant