Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-functional Boost download URLs #1844

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

speth
Copy link
Member

@speth speth commented Jan 27, 2025

Changes proposed in this pull request

Boost downloads from jfrog.io have stopped working. This seems to be approximately an annual occurrence. Switching to downloads from GitHub releases should hopefully be a more stable source.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth added the CI label Jan 27, 2025
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it’s still in draft, but this looks all good. Had looked at the same repo when failures first started.

@speth speth marked this pull request as ready for review January 28, 2025 01:19
@speth speth merged commit 37db019 into Cantera:main Jan 28, 2025
49 checks passed
@speth speth deleted the fix-boost-ci branch January 28, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants