Skip to content

Commit

Permalink
[Python/Wheel] Adjust minimum CMake version
Browse files Browse the repository at this point in the history
Set the minimum CMake version to 3.27 so that we can use upper-cased or
lower-cased *_ROOT variables to identify the locations of dependencies.
We also set the HDF5_ROOT CMake variable so that HighFive can find HDF5.
  • Loading branch information
bryanwweber authored and speth committed Dec 1, 2024
1 parent e96603d commit b77f341
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion interfaces/python_sdist/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
cmake_minimum_required(VERSION 3.24...3.30)
# Set minimum version 3.27 so that CMP0144, search for packages by upper-cased
# environment variables will use upper-cased variables. OLD behavior is to ignore
# upper-cased variables
cmake_minimum_required(VERSION 3.27...3.31)
project(${SKBUILD_PROJECT_NAME} LANGUAGES CXX)

set(CMAKE_CXX_STANDARD 17)
Expand Down
1 change: 1 addition & 0 deletions interfaces/python_sdist/pyproject.toml.in
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ make-fallback = false
[tool.scikit-build.cmake.define]
CMAKE_POSITION_INDEPENDENT_CODE = "ON"
Boost_INCLUDE_DIRS = { env = "Boost_INCLUDE_DIRS" }
HDF5_ROOT = { env = "HDF5_ROOT" }

[tool.scikit-build.sdist]
exclude = ["pyproject.toml.in", "cantera/with_units/solution.py.in"]
Expand Down

0 comments on commit b77f341

Please sign in to comment.