Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gemma support new #230

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Gemma support new #230

wants to merge 13 commits into from

Conversation

ZHIHANCHEN03
Copy link
Contributor

  1. need add_generation_prompt for Gemma to generate good response
  2. limit the response size to make sure the response is efficient
  3. no response_start_key is added since Gemma will not response correctly according to the key, then JSON format is not supported
  4. In prompt, input context is set to name as current context to make sure that Gemma and read the prompt correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmermaid goldmermaid Awaiting requested review from goldmermaid goldmermaid is a code owner

@SayaZhang SayaZhang Awaiting requested review from SayaZhang SayaZhang is a code owner

@CluckRookie CluckRookie Awaiting requested review from CluckRookie CluckRookie is a code owner

@SeisSerenata SeisSerenata Awaiting requested review from SeisSerenata SeisSerenata is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ZHIHANCHEN03