-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook example for Batch API #77
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
examples/parse_batch_fetch.ipynb:90
- [nitpick] The nested if statement could be simplified for better readability.
if markdown and markdown.result:
examples/parse_batch_fetch.ipynb:43
- Document the purpose of the MAX_WORKER variable for better understanding.
MAX_WORKER = 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comments
examples/parse_batch_fetch.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we remove these .py file and only use ipynb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we merge upload and fetch into a single notebook to ease the use
User description
Description
Related Issue
Type of Change
How Has This Been Tested?
Screenshots (if applicable)
Checklist
Additional Notes
PR Type
Documentation, Enhancement
Description
Added two new Jupyter notebooks for Batch API examples:
parse_batch_fetch.ipynb
for fetching responses.parse_batch_upload.ipynb
for uploading folders.Updated the JSONL file path in
parse_batch_fetch.py
.Added a TODO comment for status check in response processing.
Improved readability in the
README.md
documentation.Changes walkthrough 📝
parse_batch_fetch.py
Update JSONL file path and add TODO comment
examples/parse_batch_fetch.py
README.md
Improve readability in documentation list
README.md
parse_batch_fetch.ipynb
Add notebook for batch API fetch example
examples/parse_batch_fetch.ipynb
parse_batch_upload.ipynb
Add notebook for batch API upload example
examples/parse_batch_upload.ipynb