Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python SDK & bash script #22

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Update Python SDK & bash script #22

merged 5 commits into from
Apr 30, 2024

Conversation

Sdddell
Copy link
Collaborator

@Sdddell Sdddell commented Apr 26, 2024

No description provided.

@Sdddell Sdddell requested a review from CambioML as a code owner April 26, 2024 18:03
@CambioML
Copy link
Owner

qq: do we run a quick test for all notebooks in this repo after the change?

if [ "$func" == "extract" ]; then
upload
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: should upload out of the if, elif, so upload will also apply for parse logic?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm. It looks like this is a bug in previous code.

Copy link
Owner

@CambioML CambioML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's double check to make sure our notebook is still working as expected. For next PR, if you can add in the comment regarding what have been tested, it will help ease the review process a lot.

if [ "$func" == "extract" ]; then
upload
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm. It looks like this is a bug in previous code.

@Sdddell
Copy link
Collaborator Author

Sdddell commented Apr 29, 2024

I have tested all the examples, they worked fine except extract_key_values_from_cbc_reports_in_different_layout.

@CambioML CambioML merged commit 1c8b692 into CambioML:main Apr 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants