Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _QThreadWorker.run not releasing references to fulfilled command object before blocking on next queue.get call #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix _QThreadWorker.run not releasing references to fulfilled command object before blocking on next queue.get call #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3890145
Fix _QThreadWorker.run not releasing references to fulfilled command …
kormax Mar 8, 2024
d019e53
Fix _QThreadWorker.run not releasing reference to r(esult) too
kormax Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions qasync/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,15 @@ def run(self):
else:
self._logger.debug("Setting Future result: %s", r)
future.set_result(r)
finally:
# Release potential reference
r = None # noqa
else:
self._logger.debug("Future was canceled")

# Delete references
del command, future, callback, args, kwargs

self._logger.debug("Thread #%s stopped", self.__num)

def wait(self):
Expand Down