Ctpps diamond geometry 2021 #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-kaspar
reviewed
Sep 11, 2019
| <Constant name="RP_220_Right_Det_Dist_5" value=" +7.000*mm"/> | ||
|
|
||
| <!-- sector 45, diamond station --> | ||
| <Constant name="CTPPS_45_Det_Dist" value="3.0*mm"/> |
There was a problem hiding this comment.
Is this constant used for both "near" and "far" timing RPs? We should have the possibility to set the position of the RPs independently.
There was a problem hiding this comment.
RP_220_Left_Det_Dist_2 is for the new one.
CTPPS_45_Det_Dist is for the old one.
i think i might need to add a comment to make it cleaner as changing name of constant could create a need to modify more files, as it is used inside RP_Box_22 and 122.
There was a problem hiding this comment.
Added comments to the file, so unless we'd like to mess with the pot files i think this issue is solved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New detectors will not work without ctpps_diamond_reco branch.
Changes:
New Geometry Python File based on 2018, adding all the new files, removing RP_Detector_Assembly 122 and 22
Geometry/VeryForwardGeometry/python/geometryRPFromDD_2021_cfi.py
Changed the offset of new diamond detectors to be 3mm (lines 21,38)
Geometry/VeryForwardData/data/CTPPS_2021/RP_Dist_Beam_Cent.xml
New Geometry based on 2018, adding new pots with changed planes inside (lines 47-56,62-71)
Geometry/VeryForwardData/data/CTPPS_Diamond_2021/CTPPS_Diamond_Detector_Assembly.xml
New Planes 0 and 1 based off 2018 planes number 2 and 3 with changed PosParts’ copyNumbers. (VERY IMPORTANT so the mapping is applied correctly)
Geometry/VeryForwardData/data/CTPPS_Diamond_2021/CTPPS_Diamond_Planes